Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #148

Merged
merged 9 commits into from
Jun 17, 2024
Merged

Fixes #148

merged 9 commits into from
Jun 17, 2024

Conversation

chriso
Copy link
Contributor

@chriso chriso commented Jun 16, 2024 •
edited
Loading

This PR contains various fixes:

  • underscore imports are now preserved
  • interfaces with embeddeds are now supported
  • ast.Ellipsis is now handled correctly when used in a closure struct
  • ast.IndexListExpr is now supported
  • generic type params are now translated correctly when they're present in an anonymous function return value
  • reflect.Type can now be serialized

achille-roussel
achille-roussel approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a few tests to add that exercise the fixes?

@chriso chriso merged commit 892d764 into main Jun 17, 2024
2 checks passed
@chriso chriso deleted the generics-fixes branch June 17, 2024 04:58
This was referenced Jun 17, 2024
Closed
Closed
Merged
@chriso chriso self-assigned this Jun 24, 2024
chriso added a commit that referenced this pull request Jun 24, 2024
@chriso
Fixes (part 2) (#149)
9fefde4 
Following on from #148,
this PR contains various fixes:
* we now support generic type parameters that are structs
* we now conservatively register type info for all function decls/lits
in the module, and mark functions/methods in the module that contain
function literals as `noinline`, in case they create a closure that
needs to be serialized
* tweaks the logging so it generates more useful output
@chriso chriso mentioned this pull request Jun 28, 2024
Merged
chriso added a commit that referenced this pull request Jun 28, 2024
@chriso
Fixes (part 3) (#152)
0a62925 
Following on from #148 and #149, this PR contains various minor fixes:
* slices can now be used with generics
* struct tags are now supported
* lint warnings have been fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achille-roussel achille-roussel achille-roussel approved these changes

@vadimdemedes vadimdemedes Awaiting requested review from vadimdemedes

@Pryz Pryz Awaiting requested review from Pryz

@chicoxyzzy chicoxyzzy Awaiting requested review from chicoxyzzy

Assignees

@chriso chriso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriso @achille-roussel